Skip to content

Commit

Permalink
Rename setPrivate -> setReadOnly
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinpschaaf committed Apr 14, 2017
1 parent e6e4803 commit 521ed3d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/mixins/property-effects.html
Original file line number Diff line number Diff line change
Expand Up @@ -1479,14 +1479,14 @@
*
* @param {Object} props Bag of one or more key-value pairs whose key is
* a property and value is the new value to set for that property.
* @param {boolean=} setPrivate When true, any private values set in
* @param {boolean=} setReadOnly When true, any private values set in
* `props` will be set. By default, `setProperties` will not set
* `readOnly: true` root properties.
* @public
*/
setProperties(props, setPrivate) {
setProperties(props, setReadOnly) {
for (let path in props) {
if (setPrivate || !this.__readOnly || !this.__readOnly[path]) {
if (setReadOnly || !this.__readOnly || !this.__readOnly[path]) {
//TODO(kschaaf): explicitly disallow paths in setProperty?
// wildcard observers currently only pass the first changed path
// in the `info` object, and you could do some odd things batching
Expand Down

0 comments on commit 521ed3d

Please sign in to comment.