Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globals clobbering other globals #185

Closed
ryanseddon opened this issue Jun 18, 2013 · 2 comments
Closed

Globals clobbering other globals #185

ryanseddon opened this issue Jun 18, 2013 · 2 comments
Assignees
Labels

Comments

@ryanseddon
Copy link

So I've been playing around with building a simple markdown component and that component uses showdown.js now I've started noticing weird behaviour where the callstack would randomly jump into showdown.js and it's due to the fact that both libraries have a forEach global where showdown wins as it's loaded after. It's defined in the lang.js file.

Does it really need to be a global? Showdown is global crazy but it'd be nice if polymer didn't create any globals.

@sjmiles
Copy link
Contributor

sjmiles commented Jun 18, 2013

There shouldn't be any globals apart from one for each polyfill, but there is still some cleanup work to do.

@ghost ghost assigned morethanreal Sep 25, 2013
@tjsavage
Copy link
Contributor

This should be fixed, please re-open if that's not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants