Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling this.super can refer to the wrong method #373

Closed
sorvell opened this issue Dec 13, 2013 · 1 comment
Closed

Calling this.super can refer to the wrong method #373

sorvell opened this issue Dec 13, 2013 · 1 comment
Assignees
@sjmiles

Comments

@sorvell
Copy link
Contributor

sorvell commented Dec 13, 2013

The super method is currently memoized on the function object. This can cause a problem when the same function object is used in multiple elements.

For example, if a polymer-element x-element is created that extends nothing and then a polymer-element x-input is created that extends input, x-input's bind method object is shared with x-element's. That means the super bind method is shared and therefore incorrect for one of them.
@ghost ghost assigned sjmiles Dec 13, 2013
@sorvell
Copy link
Contributor Author

sorvell commented Dec 16, 2013

Addressed via: googlearchive/polymer-dev@1c59018

@sorvell sorvell closed this as completed Dec 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjmiles sjmiles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sorvell @sjmiles