Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client ready guarantee broken when setting property in manually handled notification event #4598

Closed
sorvell opened this issue May 12, 2017 · 0 comments
Assignees
Labels

Comments

@sorvell
Copy link
Contributor

sorvell commented May 12, 2017

If the following is done:

  1. a host element manually listens for a notifying event (e.g. on-foo-changed="handleFoo")
  2. a client fires the event when it initially flushes properties
  3. the host sets a property that triggers a flush in the event handler

A number of bad things happen:

  1. the host element can call readyClients twice
  2. this can lead to the shadowRoot being appended to itself which triggers Appending a shadowRoot to itself should produce consistent result webcomponents/shadydom#149
  3. the ordering guarantee that clients should be ready before host side effects are processed is broken.

This example shows #2 above: http://jsbin.com/wepamiv/edit?html,output (Note that the output should show After hi but does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant