Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a keyword in attribute name causes error in IE11 #466

Closed
warpech opened this issue Apr 3, 2014 · 4 comments
Closed

Using a keyword in attribute name causes error in IE11 #466

warpech opened this issue Apr 3, 2014 · 4 comments

Comments

@warpech
Copy link

warpech commented Apr 3, 2014

When I use a preserved HTML attribute name as one of the Polymer Element attributes, e.g.

<polymer-element name="my-elem" noscript attributes="language">
<polymer-element name="my-elem" noscript attributes="lang">
<polymer-element name="my-elem" noscript attributes="title">

Internet Explorer 11 shows exception:

TypeError: Unable to get property 'title' of undefined or null reference TypeError: Unable to get property 'title' of undefined or null reference
   at Function code (Function code:1:1)
   at publishAttributes (http://rawgithub.com/Polymer/polymer/master/polymer.js:32:18104)
   at desugarBeforeChaining (http://rawgithub.com/Polymer/polymer/master/polymer.js:32:19080)
   at buildPrototype (http://rawgithub.com/Polymer/polymer/master/polymer.js:32:18924)
   at register (http://rawgithub.com/Polymer/polymer/master/polymer.js:32:18749)
   at _register (http://rawgithub.com/Polymer/polymer/master/polymer.js:32:23549)
   at go (http://rawgithub.com/Polymer/polymer/master/polymer.js:32:21656)
   at registerWhenReady (http://rawgithub.com/Polymer/polymer/master/polymer.js:32:23342)
   at d (http://rawgithub.com/Polymer/polymer/master/polymer.js:32:12684)
   at b (http://rawgithub.com/Polymer/polymer/master/polymer.js:32:12635)

I am not sure if this is a bug (perhaps using a reserved HTML attribute name is not a good practice), but somehow this does not raise an error in Chrome nor Firefox.

JsFiddle to reproduce the issue: http://jsfiddle.net/warpech/TJhWP/1/

@sjmiles
Copy link
Contributor

sjmiles commented Apr 4, 2014

Duplicates #379

@warpech
Copy link
Author

warpech commented Apr 4, 2014

Sorry, I thought I searched for possible duplicate.

@sjmiles
Copy link
Contributor

sjmiles commented Apr 4, 2014

No worries, we need to get this fixed. Another ticket for it increases the priority.

@sorvell
Copy link
Contributor

sorvell commented Aug 12, 2014

Closed in favor of #379

@sorvell sorvell closed this as completed Aug 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants