Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymer doesn't handle data uri import links properly. #5198

Open
nicolasnoble opened this issue Apr 17, 2018 · 6 comments · May be fixed by #5199
Open

Polymer doesn't handle data uri import links properly. #5198

nicolasnoble opened this issue Apr 17, 2018 · 6 comments · May be fixed by #5199

Comments

@nicolasnoble
Copy link

nicolasnoble commented Apr 17, 2018

Description

Uncaught error when trying to create a link import element with a data uri as its href attribute.

Live Demo

https://jsbin.com/votetokeye/edit?html,output

Steps to Reproduce

  1. Create a <link> element with a data uri as its href attribute.

Expected Results

No error thrown.

Actual Results

Opening the javascript console will reveal the following:

Uncaught TypeError: Failed to construct 'URL': Invalid URL
    at Object.resolveUrl (resolve-url.html:52)
    at HTMLElement.get assetpath [as assetpath] (dom-module.html:110)
    at Function.get importPath [as importPath] (element-mixin.html:425)
    at HTMLElement._initializeProperties (element-mixin.html:469)
    at HTMLElement._initializeProperties (legacy-element-mixin.html:188)
    at new PropertiesChanged (properties-changed.html:166)
    at new PropertyAccessors (property-accessors.html:118)
    at new TemplateStamp (template-stamp.html:121)
    at new PropertyEffects (property-effects.html:1138)
    at new PropertiesMixin (properties-mixin.html:110)

Browsers Affected

All, this is a core issue.

Versions

  • Polymer: v2.6.0
  • webcomponents: v1.2.0
@stale
Copy link

stale bot commented Mar 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 13, 2020
@nicolasnoble
Copy link
Author

The staleness comes from the developers, not the reporters.

@stale stale bot removed the wontfix label Jun 1, 2020
@jkanche
Copy link

jkanche commented Jul 22, 2020

was this ever fixed ? or is there a temporary solution to this ?

@nicolasnoble
Copy link
Author

@jkanche: there's a pull request I made for it that was never merged in: #5199.

Temporary solution might simply be to apply it as a local patch.

@jkanche
Copy link

jkanche commented Jul 24, 2020

Thank you! I noticed the pull request after i made the comment earlier. It works now. I hope this gets into the release!

@stale
Copy link

stale bot commented Jul 30, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants