-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some script imports don't work when vulcanizing #706
Comments
cc @jmuk |
What are you trying to do? |
According to the readme at https://github.com/Polymer/vulcanize, running with I'm making a Chrome extension, so external scripts need to be inlined to prevent CSP errors. However, there are still some inline scripts in my project too, and if you don't also have the |
Sorry, my mistake. So, if this isn't working, it sounds like either a bug or a problem with your project setup. Are the paths to the external files relative paths that vulcanize can resolve? I've noticed that if they're absolute paths that would resolve correctly through the webserver, vulcanize can't include them. (That is, if you have (BTW, I think it would be good if vulcanize logged a message whenever it skips an external file. It might also be nice if you could specify a relative root so that you don't have to change your paths to vulcanize a site.) |
Hmm, none of the paths are absolute, but they are outside the main project directory. Since it's an official Google project all the Polymer components have to be in It would definitely be good for Vulcanize to show a warning when files are skipped. |
Closing this issue due to age and the release of version 1 of Polymer - please feel free to re-open if this is incorrect. |
This is the issue that lead to me discovering #705. When running a Polymer app through vulcanize with both the
--csp
and--inline
flags, external scripts won't be imported into the component.So, in a component,
will work, but
where
my-foo.js
containswill not work.
The text was updated successfully, but these errors were encountered: