Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-media-recorder throws error when stream is null #46

Closed
JaySunSyn opened this issue Mar 8, 2018 · 1 comment
Closed

app-media-recorder throws error when stream is null #46

JaySunSyn opened this issue Mar 8, 2018 · 1 comment

Comments

@JaySunSyn
Copy link
Contributor

JaySunSyn commented Mar 8, 2018 •
edited
Loading

Description

app-media-stream sets its stream property to null if active gets set to false.

app-media-recorder tries to re-compute the recorder property with a nullified stream. => throws error.

Expected outcome

No error.

Actual outcome

Uncaught TypeError: Failed to construct 'MediaRecorder': parameter 1 is not of type 'MediaStream'.

Steps to reproduce

Bind stream from app-media-stream to app-media-recorder.
Set active property of app-media-stream to false.
@JaySunSyn JaySunSyn mentioned this issue Mar 8, 2018
Merged
@cdata
Copy link
Contributor

cdata commented Mar 18, 2018

Should be fixed by #47

@cdata cdata closed this as completed Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdata @JaySunSyn