Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Move <script> inside <dom-module> #25

Closed
cherukumilli opened this issue Jan 25, 2016 · 2 comments
Closed

Move <script> inside <dom-module> #25

cherukumilli opened this issue Jan 25, 2016 · 2 comments
Assignees

Comments

@cherukumilli
Copy link

gold-zip-input's code is not following the same standards as other elements. gold-zip-input's javascript code is outside the . All other elements have javascript code inside the tags

Current gold-zip-input code:

...
<dom-module>
   ...
</dom-module>
<script>
   ...
</script>

Expected:

...
<dom-module>
   ...
   <script>
      ...
   </script>
</dom-module>

A similar issue has been fixed for other elements like paper-fab. Please check PolymerElements/paper-fab#53 for details.

@notwaldorf
Copy link
Contributor

Hi! Thanks for pointing this out! Would you be interested in sending a PR for that? 😻

@notwaldorf
Copy link
Contributor

Fixed in #26

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants