Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number pad digit keys not handled properly #30

Closed
adegruchy opened this issue Dec 29, 2015 · 0 comments
Closed

Number pad digit keys not handled properly #30

adegruchy opened this issue Dec 29, 2015 · 0 comments

Comments

@adegruchy
Copy link

When passed through the normalizedKeyForEvent function, key events for number pad digits are incorrectly transformed because the keyIdentifier property for the event has the same Unicode value as a-i.

The keyIdentifier property is deprecated and non-standard (API), so this check should be removed, or at least placed below the check for the keyCode property.

If the transformKeyIdentifier check is put below the transformKeyCode check, an issue with the transformKeyCode function becomes apparent when testing number keys. The keyCode parameter should have 48 and 96 subtracted from it for top row numeric keys and number pad digits respectively, not the other way around.

I've created a pull request for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants