New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'esc' not matched for escape key in Chrome Canary, breaking menus #38

Closed

mgiuffrida opened this issue Mar 31, 2016 · 2 comments

Contributor

mgiuffrida commented Mar 31, 2016

An update to Chrome's treatment of KeyboardEvent (see intent to ship) has broken iron-a11y-keys-behavior's matching logic for the Escape key. This is preventing, for example, Escape from closing paper-dropdown-menu because iron-menu-behavior treats the key as if it were supposed to be the first character of a menu item.

This is affecting Chrome's new Material Design Downloads page as a beta-blocking issue.

A fix has been proposed (not formatted a patch for this repo though).

Open questions:

Do any other keys not work?
Is the proposed fix compatible with other browsers?

mgiuffrida mentioned this issue

Support Escape DomKey #39

Merged

Contributor Author

mgiuffrida commented Apr 1, 2016

FTR, this also prevents Escape from closing dialogs.

Member

valdrinkoshi commented Apr 1, 2016

Closing, got fixed in #39 & released in v1.1.2

valdrinkoshi closed this as completed

valdrinkoshi mentioned this issue

shift+tab doesn't focus the previous input PolymerElements/paper-input#283

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment