Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection Error handling #17

Closed
nicoswan opened this issue May 10, 2015 · 2 comments
Closed

Connection Error handling #17

nicoswan opened this issue May 10, 2015 · 2 comments

Comments

@nicoswan
Copy link

This is a request to handle connection issues better in core-ajax connection issues returned a response of 0 might be better to return the actual error i.e. net::ERR_NAME_NOT_RESOLVED
@cdata
Copy link
Contributor

cdata commented May 11, 2015

Status code 0 seems to be ambiguous. file:// protocol requests that succeed have a status code of 0, for example. We are probably going to end up handling 0 as a success. Would you be willing to provide any arguments in favor of handling it as an error?

@cdata
Copy link
Contributor

cdata commented May 12, 2015

This is partially addressed in #19. Please re-open if you think there is still a problem.

@cdata cdata closed this as completed May 12, 2015
@ghost ghost mentioned this issue Jun 18, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdata @nicoswan