Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout and behavior broken in flexbox environments #52

Closed
3 of 8 tasks
timove opened this issue Apr 26, 2016 · 6 comments · Fixed by #53
Closed
3 of 8 tasks

layout and behavior broken in flexbox environments #52

timove opened this issue Apr 26, 2016 · 6 comments · Fixed by #53

Comments

@timove
Copy link
Contributor

timove commented Apr 26, 2016

Description

In certain flexbox environments iron-collapse fails to visually collapse itself and to report transitionend events. The flex character suppresses the height changes visually.

Expected outcome

Visually collapsing iron-collapse and fired transitionend events.

Actual outcome

No animation visible, content remains visible, no transitionend events.

Live Demo

Steps to reproduce

See failing test in timove@eec525b

Browsers Affected

Verified for, otherwise untested:

  • Chrome
  • Firefox
  • Safari 9
  • Safari 8
  • Safari 7
  • Edge
  • IE 11
  • IE 10
@timove timove mentioned this issue Apr 26, 2016
@valdrinkoshi
Copy link
Member

Could not reproduce, the events are correctly fired: here http://jsbin.com/mecaha/1/edit?html,console,output
In those tests you have the iron-collapse already opened, hence you should not see any animation. If the status is toggled after the collapse gets attached, you should see the animation.
Closing for now, will reopen if the problem persists. A jsbin showing the issue would be much appreciated 👍

@timove
Copy link
Contributor Author

timove commented May 24, 2016

In your jsbin, the iron-flex-layout classes "layout, vertical" do not get applied to the container surrounding the iron-collapse. Here is a fixed version: http://jsbin.com/xudawucomo/1/edit?html,console,output
I added a red background to illustrate the issue. transitionend does not fire every 2nd time toggle is clicked. Can you confirm this?

@valdrinkoshi
Copy link
Member

@timove yes i confirm that transitionend doesn't get fired when iron-collapse is opened.
For your use case, I would rather suggest to wrap the iron-collapse with another div and make it flex, like this http://jsbin.com/gipaceruci/edit?html,output
WDYT?

@timove
Copy link
Contributor Author

timove commented May 25, 2016

@valdrinkoshi Unfortunately, in my use case this does not work. I cannot tell why, yet. I have nested iron-collapse elements which show really awkward behaviors without my proposed fixed. --- Do you see problems applying the fix?

@valdrinkoshi
Copy link
Member

Oh, I forgot reopening the issue sorry!
Will review your PR & see if this is a breaking change or not 😉

@valdrinkoshi
Copy link
Member

valdrinkoshi commented Jun 7, 2016

Fixed by #53 and released in v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants