Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong positioning when embedding in a flex container #17

Closed
timeu opened this issue Jul 22, 2015 · 2 comments
Closed

Wrong positioning when embedding in a flex container #17

timeu opened this issue Jul 22, 2015 · 2 comments

Comments

@timeu
Copy link

timeu commented Jul 22, 2015

When putting a paper-dialog and a paper-dialog-scrollable' inside a body that has the classesfullbleed,verticalandlayout`, the offset will be wrong.

Reproducable: https://jsbin.com/dizison/edit?html,output
If you remove the layout and vertical classes from the body tag it will work fine.

The problem is that this line will result in a negative offset:
https://github.com/PolymerElements/iron-fit-behavior/blob/master/iron-fit-behavior.html#L229

@cdata
Copy link
Contributor

cdata commented Oct 19, 2015

I'm sorry, but the reported issue is a little too vague to be actionable. Can you provide screenshots of the expected result and the actual result from your test case, and then re-open? Thanks!

@cdata cdata closed this as completed Oct 19, 2015
@timeu
Copy link
Author

timeu commented Oct 20, 2015

It seems that the issue isn't reproducable anymore.

Soem more infos:
When I created the issue, the problem was, that the dialog was bigger than the visible screen because var sizingOffset = this[offsetExtent] - this.sizingTarget[offsetExtent]; returned a negative value (when the body was flexed) and thus maxHeight was bigger than it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants