-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why flex-1
factor has a flex-basis
attribute and other factors don't ?
#87
Comments
This might be related to IE10 compatibility: Polymer/polymer#1097 |
Oof, we should investigate if this is still needed. It was originally there because IE10's flexbox is really messed up, and needs the weird flex basis; I think we should either add it to all the flex factors, or remove it from |
cc/ @danbeam @mgiuffrida Same question for the "flex" class. Pasting from https://bugs.chromium.org/p/chromium/issues/detail?id=635633#c11 In @notwaldorf: Is there a reason for the flex-basis to exist? This is effectively blocking the transition from the deprecated |
TBH, I think it was an IE10 quirk. I think we can definitely fix this in the 2.0-preview branch, but I have soooome IE10 worries about fixing it on master. :/ |
(but if we can test that changing that flex basis doesn't break the tests in IE10, that's probably sufficient) |
@notwaldorf could we get away with using the weird basis value only with |
Hello,
I just spent some time wondering why my different flex boxes with a
flex-2
class weren't of the same height in a vertical layout (height was varying depending on the content).I had another working example with boxes using
flex
class with "fixed" heights.I found on the net that the
grow
attribute was related to aflex-basis
factor, and to assure elements to be the exact same height/width, thisflex-basis
attribute had to be 0.Then I noticed that this factor was set to ~0 only on the
flex-1
class.Is this behavior has been developed in a purpose ?
Thanks for your help
The text was updated successfully, but these errors were encountered: