-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"id" pollutes global namespace #17
Comments
This isn't really a problem in the shadow DOM, since elements are scoped (so the 'id' is only scoped to that particular instance of |
Are you sure? It seems to me that the elements using 'id' are in light dom not shadow dom. Please correct me if I'm wrong. |
So, after some investigation on the Slack, we came to this conclusion:
FWIW, it appears to me that using IDs for SVG defs is the standard way to reference defs (and possibly the only way? I'm not sure): http://www.w3.org/TR/SVG11/struct.html#Overview The questions are:
Copying @azakus who's familiar with both the iconsets and vulcanize ... |
Handing this over to himself. If you think this is just something we should doc & live with, go ahead and assign it back to me and I'll Make It So. |
We should consider using an alternate attribute for the unique ID (maybe |
This issue still persists with Polymer 3.0 |
It seems to me this issue still applies :
googlearchive/core-iconset-svg#3
Is it not trivial to use some other attribute than 'id' to avoid conflicts with other ids used in the DOM?
The text was updated successfully, but these errors were encountered: