Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permanent, persistent and temporary modes #121

Closed
Zecat opened this issue Jan 5, 2016 · 1 comment
Closed

permanent, persistent and temporary modes #121

Zecat opened this issue Jan 5, 2016 · 1 comment

Comments

@Zecat
Copy link

Zecat commented Jan 5, 2016

From the spec, the drawer can be

So I propose some changes on attributes :

  • replace "responsiveWidth" by "tabletWidth" and "mobileWidth"
  • replace "narrow" by "mobile", "tablet" and "desktop"
  • remove "forceNarrow"
  • add "tabletMode" and "desktopMode" ( = "permanent" | "persistent" | "temporary")
@Zecat Zecat changed the title add "mode" attribute permanent, persistent and temporary modes Jan 5, 2016
@blasten
Copy link
Contributor

blasten commented Jan 5, 2016

hmm. I would recommend taking a look at app-layout, so you can see where we are going to. https://github.com/PolymerLabs/app-layout

We'd keep this into consideration for the API design of app-drawer-layout, but I believe the code to explicitly support these modes should belong to the application rather than the element itself. In that way, the API of the element remains granular and it can support more use cases/designs.

I've moved this issue to PolymerElements/app-layout#38

@blasten blasten closed this as completed Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants