Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Suggestion: improve doc about Firebase Pretty URLs #670

Closed
felpsio opened this issue Jan 22, 2016 · 3 comments
Closed

Suggestion: improve doc about Firebase Pretty URLs #670

felpsio opened this issue Jan 22, 2016 · 3 comments

Comments

@felpsio
Copy link

felpsio commented Jan 22, 2016

I had a lot of problems when using Pretty URLs in Firebase, even following the guide: https://github.com/PolymerElements/polymer-starter-kit/blob/master/docs/deploy-to-firebase-pretty-urls.md

I discovered that the tag <base href="/"> should come first in the index.html. When this tag was the last line of the <head> tag the browser had a lot of problems when finding the elements. But, if you put this tag just after the starting of the <head> and before any kind of import it works perfectly.

So, I would like to suggest changing the step text
"Add <base href="/"> to head in index.html"
to
"Add <base href="/"> in the beggining of the head in index.html"

@samccone
Copy link
Contributor

👍 this seems like a reasonable change to me, good idea @felipecesar00
Any interest in opening up a PR?

@felpsio
Copy link
Author

felpsio commented Jan 22, 2016

I don't. Fell free to change :). I believe this detail will help many devs spend less time on solving routing problems :)

@chuckh
Copy link
Contributor

chuckh commented Jan 22, 2016

I created pr #671 with this change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants