This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Fix behavior themes in Google Chrome #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Chrome themes wouldn't behave well, styles would disappear whenever the theme changed or whenever the editor was re-initialized. This fixes that problem.
|
I signed the CLA just now by the way. |
|
How's that? |
| @@ -59,6 +59,24 @@ | |||
| // this.editor is not set, we create a dummy editor. At editor | |||
| // initialization time, any pending changes are synch'd. | |||
| ready: function() { | |||
| ace.require("ace/lib/dom").importCssString = function(cssText, id) { | |||
| if (this.styles[id]) { | |||
There was a problem hiding this comment.
I tried this fix in Atom Shell (Chromium) and I get an exception here if I don't initialise this.styles.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I used the ace element in Chrome the themes wouldn't behave well. Whenever I changed the theme or re-initialized the ace-element then all styles on the editor would disappear. This fixes that problem.
I didn't fix this problem myself, credits go to nightwing who helped me here