Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

update version of command-line-args which also now requires command-line-usage #3

Merged
merged 2 commits into from Oct 31, 2016

Conversation

zzo
Copy link
Contributor

@zzo zzo commented Oct 27, 2016

can now work with node6

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@zzo
Copy link
Contributor Author

zzo commented Oct 27, 2016

I signed it!

Copy link
Contributor

@rictic rictic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One small change, and it looks like you'll want to double check the email you used with these commits.

@@ -1,6 +1,6 @@
{
"name": "polymer-css-build",
"version": "0.0.6",
"version": "0.0.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't update the version number in a pull request, we'll do that when we stamp a new release based on any other unreleased changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok done

@rictic
Copy link
Contributor

rictic commented Oct 28, 2016

/cc @azakus What's up with the tests being red here?

Committer: Mark Trostler <mark@zzo.com>

Committer: Mark Trostler <mark@zzo.com>
@dfreedm
Copy link
Member

dfreedm commented Oct 31, 2016

Hmm, not sure why the tests are failing, but LGTM

@dfreedm dfreedm merged commit 0e312b7 into Polymer:master Oct 31, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants