You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.
causes the demo to break. The <footer> part does not update with the values.
I think the issue is probably that we can't replaceChild inside of the walker loop. Maybe the solution is to defer dom mutations until after the loop is complete.
The text was updated successfully, but these errors were encountered:
I was able to fix this by putting the mutation into a queue and running that queue after the while loop. Not sure if that is correct or not though. If acceptable I can send a PR over.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This line:
template-instantiation/src/template-definition.ts
Line 61 in 05a1867
causes the demo to break. The
<footer>
part does not update with the values.I think the issue is probably that we can't replaceChild inside of the walker loop. Maybe the solution is to defer dom mutations until after the loop is complete.
The text was updated successfully, but these errors were encountered: