Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught Type Error on removal #6

Open
DrNiels opened this issue Jan 18, 2018 · 1 comment
Open

Uncaught Type Error on removal #6

DrNiels opened this issue Jan 18, 2018 · 1 comment

Comments

@DrNiels
Copy link
Contributor

DrNiels commented Jan 18, 2018

When I remove the editor element (or one of its parents), an error is displayed in the console:

monaco-editor-iframe.js:87 Uncaught TypeError: Cannot read property 'postMessage' of null
    at EditorProxy.postMessage (monaco-editor-iframe.js:87)
    at EditorProxy.dispose (monaco-editor-iframe.js:111)
    at HTMLElement.disconnectedCallback (monaco-editor.html:487)
    at HTMLElement.closeTab (tabbed-shell.html:665)
    at HTMLElement._handleCloseEvent (tabbed-shell.html:480)
    at HTMLElement._close (ips-tab.html:60)
    at HTMLElement.handler (template-stamp.html:92)
    at Object._fire (gestures.html:599)
    at Object.forward (gestures.html:991)
    at Object.click (gestures.html:957)````

So far, I could not observe any further effects of this error beside the message.
@eterna2
Copy link
Contributor

eterna2 commented Jan 18, 2018

Thanks. I will look into it. Seems like we did not remove some of the bindings properly when u remove the editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants