Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 馃幐 Update polkadot types with 5.2.0 chain #922

Merged
merged 7 commits into from
Jan 30, 2023
Merged

Conversation

prashantasdeveloper
Copy link
Collaborator

Description

Update all polkadot types and metadata to make SDK compatible with 5.2.0 chain

Breaking Changes

NA

JIRA Link

DA-496

Checklist

  • Updated the Readme.md (if required) ?

Copy link
Collaborator

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but there are a lot of tests to update

@prashantasdeveloper prashantasdeveloper marked this pull request as ready for review January 23, 2023 14:24
Copy link
Collaborator

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we update SUPPORTED_SPEC_VERSION_RANGE to 5.2.0?

Copy link
Collaborator

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think we should make a beta release from whats in alpha now. Looks like the diff is large

I don't want to debug any schema issues bundled alongside a 50+ file change set

@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@polymath-eric polymath-eric merged commit 8ea7fbd into alpha Jan 30, 2023
@polymath-eric polymath-eric deleted the feat/DA-496 branch January 30, 2023 21:20
@prashantasdeveloper
Copy link
Collaborator Author

馃帀 This PR is included in version 19.0.0-alpha.16 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@prashantasdeveloper
Copy link
Collaborator Author

馃帀 This PR is included in version 19.0.0-alpha.17 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@prashantasdeveloper
Copy link
Collaborator Author

馃帀 This PR is included in version 19.0.0-beta.6 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@prashantasdeveloper
Copy link
Collaborator Author

馃帀 This PR is included in version 19.0.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants