Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hashicorp-vault-signing-manager): fix long message signing #18

Merged
merged 1 commit into from
Oct 8, 2022
Merged

fix(hashicorp-vault-signing-manager): fix long message signing #18

merged 1 commit into from
Oct 8, 2022

Conversation

adamdossa
Copy link
Contributor

Description

Breaking Changes

JIRA Link

Checklist

  • Updated the Readme.md (if required) ?

@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

polymath-eric
polymath-eric approved these changes Oct 8, 2022
View reviewed changes
Copy link
Collaborator

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for figuring out the fix for this!

@polymath-eric polymath-eric merged commit c25ead8 into main Oct 8, 2022
@polymath-eric polymath-eric deleted the fix-long-signing-messages branch October 8, 2022 20:19
prashantasdeveloper pushed a commit that referenced this pull request Oct 8, 2022
@semantic-release-bot
chore(release): 📦 hashicorp-vault-signing-manager@1.1.1 [skip ci]
cf2703c 
## [1.1.1](https://github.com/PolymeshAssociation/signing-managers/compare/@polymeshassociation/hashicorp-vault-signing-manager@1.1.0...@polymeshassociation/hashicorp-vault-signing-manager@1.1.1) (2022-10-08)

### Bug Fixes

* **hashicorp-vault-signing-manager:** fix long message signing ([#18](#18)) ([c25ead8](c25ead8))
@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/hashicorp-vault-signing-manager@1.1.1 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/approval-signing-manager@1.0.0 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/signing-manager-types@1.1.1 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/browser-extension-signing-manager@1.1.1 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/local-signing-manager@1.2.1 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/fireblocks-signing-manager@1.0.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polymath-eric polymath-eric polymath-eric approved these changes

@VictorVicente VictorVicente Awaiting requested review from VictorVicente VictorVicente is a code owner

@prashantasdeveloper prashantasdeveloper Awaiting requested review from prashantasdeveloper prashantasdeveloper is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamdossa @prashantasdeveloper @polymath-eric