Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(local-signing-manager): update comment wording #34

Merged
merged 3 commits into from
Feb 6, 2023
Merged

docs(local-signing-manager): update comment wording #34

merged 3 commits into from
Feb 6, 2023

Conversation

MehdiRaash
Copy link
Contributor

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@polymath-eric polymath-eric merged commit fb95679 into PolymeshAssociation:main Feb 6, 2023
@polymath-eric polymath-eric deleted the refactor/comment-wording branch February 6, 2023 17:16
prashantasdeveloper pushed a commit that referenced this pull request Feb 6, 2023
@semantic-release-bot
chore(release): 📦 local-signing-manager@1.4.1 [skip ci]
b8bfd9a 
## [1.4.1](https://github.com/PolymeshAssociation/signing-managers/compare/@polymeshassociation/local-signing-manager@1.4.0...@polymeshassociation/local-signing-manager@1.4.1) (2023-02-06)

### Documentation

* **local-signing-manager:** update comment wording ([#34](#34)) ([fb95679](fb95679))
@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/local-signing-manager@1.4.1 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/signing-manager-types@1.2.2 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/browser-extension-signing-manager@1.1.4 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/hashicorp-vault-signing-manager@1.1.7 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/fireblocks-signing-manager@1.0.4 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/approval-signing-manager@1.0.6 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polymath-eric polymath-eric polymath-eric approved these changes

@VictorVicente VictorVicente Awaiting requested review from VictorVicente VictorVicente is a code owner

@prashantasdeveloper prashantasdeveloper Awaiting requested review from prashantasdeveloper prashantasdeveloper is a code owner

@sansan sansan Awaiting requested review from sansan sansan is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MehdiRaash @prashantasdeveloper @polymath-eric