fix(*): main field in package.json to reference index.js correctly #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polymath-eric
requested review from
VictorVicente,
prashantasdeveloper and
sansan
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
VictorVicente
approved these changes
Mar 17, 2023
prashantasdeveloper
pushed a commit
that referenced
this pull request
Mar 17, 2023
## [1.2.2](https://github.com/PolymeshAssociation/signing-managers/compare/@polymeshassociation/signing-manager-types@1.2.1...@polymeshassociation/signing-manager-types@1.2.2) (2023-03-17) ### Bug Fixes * main field in package.json to reference index.js correctly ([#36](#36)) ([66e8c44](66e8c44))
|
🎉 This PR is included in version @polymeshassociation/signing-manager-types@1.2.2 🎉 The release is available on: |
prashantasdeveloper
pushed a commit
that referenced
this pull request
Mar 17, 2023
## [1.1.4](https://github.com/PolymeshAssociation/signing-managers/compare/@polymeshassociation/browser-extension-signing-manager@1.1.3...@polymeshassociation/browser-extension-signing-manager@1.1.4) (2023-03-17) ### Bug Fixes * **browser-extension-signing-manager:** ⬆️ update @polymeshassociation/signing-manager-types to 1.2.2 [skip ci] ([f7f6445](f7f6445)) * main field in package.json to reference index.js correctly ([#36](#36)) ([66e8c44](66e8c44))
|
🎉 This PR is included in version @polymeshassociation/browser-extension-signing-manager@1.1.4 🎉 The release is available on: |
prashantasdeveloper
pushed a commit
that referenced
this pull request
Mar 17, 2023
## [1.1.7](https://github.com/PolymeshAssociation/signing-managers/compare/@polymeshassociation/hashicorp-vault-signing-manager@1.1.6...@polymeshassociation/hashicorp-vault-signing-manager@1.1.7) (2023-03-17) ### Bug Fixes * **hashicorp-vault-signing-manager:** ⬆️ update @polymeshassociation/signing-manager-types to 1.2.2 [skip ci] ([4f90c6f](4f90c6f)) * main field in package.json to reference index.js correctly ([#36](#36)) ([66e8c44](66e8c44))
|
🎉 This PR is included in version @polymeshassociation/hashicorp-vault-signing-manager@1.1.7 🎉 The release is available on: |
prashantasdeveloper
pushed a commit
that referenced
this pull request
Mar 17, 2023
## [1.0.4](https://github.com/PolymeshAssociation/signing-managers/compare/@polymeshassociation/fireblocks-signing-manager@1.0.3...@polymeshassociation/fireblocks-signing-manager@1.0.4) (2023-03-17) ### Bug Fixes * **fireblocks-signing-manager:** ⬆️ update @polymeshassociation/signing-manager-types to 1.2.2 [skip ci] ([df156e1](df156e1)) * main field in package.json to reference index.js correctly ([#36](#36)) ([66e8c44](66e8c44))
|
🎉 This PR is included in version @polymeshassociation/fireblocks-signing-manager@1.0.4 🎉 The release is available on: |
prashantasdeveloper
pushed a commit
that referenced
this pull request
Mar 17, 2023
## [1.0.6](https://github.com/PolymeshAssociation/signing-managers/compare/@polymeshassociation/approval-signing-manager@1.0.5...@polymeshassociation/approval-signing-manager@1.0.6) (2023-03-17) ### Bug Fixes * **approval-signing-manager:** ⬆️ update @polymeshassociation/signing-manager-types to 1.2.2 [skip ci] ([aff71f2](aff71f2)) * main field in package.json to reference index.js correctly ([#36](#36)) ([66e8c44](66e8c44))
|
🎉 This PR is included in version @polymeshassociation/approval-signing-manager@1.0.6 🎉 The release is available on: |
prashantasdeveloper
pushed a commit
that referenced
this pull request
Mar 17, 2023
## [1.4.2](https://github.com/PolymeshAssociation/signing-managers/compare/@polymeshassociation/local-signing-manager@1.4.1...@polymeshassociation/local-signing-manager@1.4.2) (2023-03-17) ### Bug Fixes * **local-signing-manager:** ⬆️ update @polymeshassociation/signing-manager-types to 1.2.2 [skip ci] ([123f154](123f154)) * main field in package.json to reference index.js correctly ([#36](#36)) ([66e8c44](66e8c44))
|
🎉 This PR is included in version @polymeshassociation/local-signing-manager@1.4.2 🎉 The release is available on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By adding main in the projects package.json, nx will use the proper reference in final package, while looking at src when developing.
I noticed the warning come up when I was trying various build things, so I figured I should fix this.
I also added a repository reference as seen here. I looked at a polkadot package for the format. I saw lib grading tool dock marks for not having it. Probably something we should add in other repos as well.
Breaking Changes
None
JIRA Link
DA-547
Checklist