Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creature's body shouldn't have so many shadows, especially when he grows #50

Closed
Poobslag opened this issue Mar 25, 2020 · 2 comments · Fixed by #455
Closed

Creature's body shouldn't have so many shadows, especially when he grows #50

Poobslag opened this issue Mar 25, 2020 · 2 comments · Fixed by #455
Labels
priority-3 This is very noticable. It should be completed, certain players would consider it a "must have".
Milestone

Comments

@Poobslag
Copy link
Owner

At a small size, the customer's torso is in shadow because his head casts a shadow. At larger sizes, his head is dwarfed by his body and his body should be mostly illuminated, except for the areas directly beneath his head, arms, and legs.

The same is true for his arms and legs, which also have shadows from his head. We don't need anything too complex, but maybe just two arm/leg images based on when the head's shadow shrinks past the shoulders.

@Poobslag Poobslag added the priority-3 This is very noticable. It should be completed, certain players would consider it a "must have". label May 1, 2020
@Poobslag
Copy link
Owner Author

Additionally, the shadows that are there should be significantly darker. They should match the shadow darkness on the overworld, right now they're too subtle

@Poobslag Poobslag changed the title Customer's body shouldn't have so many shadows, especially when he grows Creature's body shouldn't have so many shadows, especially when he grows Jun 8, 2020
@Poobslag Poobslag added this to the v0.09 milestone Jun 8, 2020
@Poobslag Poobslag linked a pull request Jul 10, 2020 that will close this issue
@Poobslag
Copy link
Owner Author

I've kept the shadows light. They look OK as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3 This is very noticable. It should be completed, certain players would consider it a "must have".
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant