Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When switching from YouTube straight to other app using dock or app manager, PiP freezes and/or speeds up. #29

Closed
reticivis-net opened this issue Aug 14, 2021 · 27 comments

Comments

@reticivis-net
Copy link

Upload.from.GitHub.for.iOS.MOV

iOS 14.2, iPad Pro 11 inch 2nd generation, taurine 1.0.4, youpip 1.5.7

@reticivis-net
Copy link
Author

Sometimes this happens when going to the Home Screen too though I'm not entirely sure why. Seems to be more reproducible when just switching apps.

@reticivis-net
Copy link
Author

Fixed with the "PiP sample buffer hack" option. I highly reccomend you move the tweak options out of the YouTube app and into settings where they normally are so people can find them easier. At least mention it on the package page.

@PoomSmart
Copy link
Owner

  1. Sample Buffer Hack doesn't always solve the issue for everyone
  2. I will update package depiction later to mention about that hack

@reticivis-net
Copy link
Author

Yeah I started having the issue again after I closed this so I'll just reopen this in the hope a permanent solution is found

@NguyenASang
Copy link
Contributor

@PoomSmart Any better solution for this error ?

@PoomSmart
Copy link
Owner

@NguyenASang Nothing at the moment.

@NguyenASang
Copy link
Contributor

@PoomSmart Can you reopen it as it's still not fully fixed.

@PoomSmart PoomSmart reopened this Dec 19, 2021
@reticivis-net
Copy link
Author

Can confirm that I've been experiencing this issue for a while now. Sample buffer hack doesn't appear to have any affect. Still on iOS 14.3

@NguyenASang
Copy link
Contributor

@HexCodeFFF Does this happen when you enable pip with the pip button?

@reticivis-net
Copy link
Author

No, I'm not able to easily reproduce it with the pip button. Like I said in the main issue, it seems to be an issue that occurs when enabling pip as you switch apps

@NguyenASang
Copy link
Contributor

@HexCodeFFF You mean sometimes it happens when you use pip button but when using auto pip it always happens ?

@reticivis-net
Copy link
Author

It never happens with the pip button and sometimes happens with auto pip. Seemingly when you switch directly to another app the bug occurs and will keep occurring on new videos until you restart the app

@NguyenASang
Copy link
Contributor

NguyenASang commented Dec 21, 2021

@HexCodeFFF I think this happened with the "Auto pip" code. @PoomSmart Can you rewrite that code ? Maybe rewrite it can help you to find the bug code.

@reticivis-net
Copy link
Author

If I had to guess what was going on, it seems that switching to another app or otherwise exiting YouTube right as pip has to trigger confuses it and possibly sets youtube into a mode where it's buffering video as fast as possible since it thinks it's only background playing audio. Maybe look into interrupting YouTube's exit to make sure it's properly set up for pip. Maybe ask udevs how they got Bakgrunnur working?

This is all just a guess and it could be wrong

@NguyenASang
Copy link
Contributor

@HexCodeFFF yes, I don't understand this program language so I can't be sure how it works, for now we can only hope @PoomSmart can fix this.

@PoomSmart
Copy link
Owner

I myself are stuck at this also. If I had any updates then you would see an announcement. No precise ETA.

@NguyenASang
Copy link
Contributor

Hope this bug can be fixed soon :D

@NguyenASang
Copy link
Contributor

NguyenASang commented Dec 22, 2021

@PoomSmart How does Auto PiP work? Detect swipe up gesture? Hmmm Does that error happen with the iPhone or only iPad ?

@reticivis-net
Copy link
Author

Likely works on app exit event or adapts YouTube to work for the already existing PiP in iOS

I haven't tested it on iPhone especially cause native pip for iPhone is an experimental YouTube feature so there might be code to make it work there

@NguyenASang
Copy link
Contributor

NguyenASang commented Dec 22, 2021

@HexCodeFFF Can you test it on iPhone? If my thinking is correct, the problem does not occur with the iPhone (I'm wrong :// )

@reticivis-net
Copy link
Author

I reproduced the glitch on iPhone. You have to tap on a notification while a video is playing.

Upload.from.GitHub.for.iOS.MOV

@NguyenASang
Copy link
Contributor

@HexCodeFFF This problem I think caused by suddenly switch to another app. Does the code support this case @PoomSmart ?

@reticivis-net
Copy link
Author

Update: the glitch happened while using the pip button :/

@NguyenASang
Copy link
Contributor

Weird moment :// We stuck here :|

@NguyenASang
Copy link
Contributor

@PoomSmart So, we can't find what part of the code is causing that error ?

@PoomSmart
Copy link
Owner

PoomSmart commented Jan 5, 2022

I'm writing this message to remind you of the message I replied here 15 days ago. Bugging in this thread will do no good.

@PoomSmart
Copy link
Owner

The only workaround is to use Legacy PiP, I couldn't find a way to resolve this - and I don't know any iOS 14 devices anymore.

@PoomSmart PoomSmart closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants