Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine drag cubes part II #364

Merged
merged 2 commits into from
Feb 11, 2019
Merged

Engine drag cubes part II #364

merged 2 commits into from
Feb 11, 2019

Conversation

DMagic1
Copy link
Contributor

@DMagic1 DMagic1 commented Feb 11, 2019

Many engines were set to procedural drag cubes because they were using both ModulePartVariant and ModuleJettison to modify drag cubes; only one can be active at the same time so the system reverts to using procedural cubes.

This fixes that for 1.25m, 2.5m, and 3.75m engines, they now only use ModulePartVariant to modify drag cubes (further modifications to some these engines' drag cubes will most likely be necessary). The LV-N remains procedural because of its weird double shroud setup.

The Flea and Hammer SRBs were set to use ModuleJettison to modify drag cubes, as their variants were purely cosmetic.

@ChrisAdderley ChrisAdderley merged commit a852c66 into PorktoberRevolution:master Feb 11, 2019
@theonegalen
Copy link

theonegalen commented Feb 12, 2019

Does this mean that the jettisonable fairings will not actually change the drag value of the parts? In that case, should players start using the stock procedural fairings as interstages instead of the auto fairings?

@DMagic1
Copy link
Contributor Author

DMagic1 commented Feb 12, 2019

There has been much discussion about this, the basic problem is that you can either have the engine shrouds modify the drag cubes, or the part variants modify the drag cubes but not both.

For vacuum engines, or other engines that are almost entirely expected to be used in the middle of a stack the better solution is to use engine shrouds to modify drag cubes, and to manually set the drag cube for the unshrouded version to be that of the smallest engine variant.

For engines more likely to go on the end of a stack, at least while in the atmosphere, it makes more sense to modify the drag cubes based on the engine variant (with some tweaking - OHara has some thoughts on this that I will check out at some point: https://bugs.kerbalspaceprogram.com/issues/20683)

In any case, this PR doesn't address either of those issues. Many of the engines in ReStock have their configs set use both ModuleJettison and ModulePartVariants to modify drag cubes (the field "useMultipleDragCubes" defaults to true in both cases). KSP doesn't support that, so the engines revert to using procedural drag cubes, which generates performance overhead and an end result that is more-or-less the same as using engine variant-based drag cubes.

The vacuum engine drag was addressed in #351 and the other engines will need to be addressed later.

@theonegalen
Copy link

Makes sense. Thank you for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants