Drag fixes for hollow parts and cosmetic variants #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plug the drag hole in the tall 2.5m to 1.25m adaptor. Plug the drag hole in the toroid fuel tank. Plug the drag holes in the large and small stack probe cores. Let the 0.625m heat shield generate cubes for the shrouded and unshrouded versions.
The YP and YN values are taken from their stock counterparts. The other values are as generated for ReStock meshes.
|
I'm good for this except for the heat shield change - we do need a way to preserve the stock heat shield's drag cube here because it has considerable effects on occlusion and some effects on thermal behaviour. |
|
In that case it should be as updated. The "Clean" value is taken directly from the stock drag cube. The shrouded value is what the system generates for the ReStock heat shield, and should actually match the 0.625m drag profile better. |
|
Looks good then! merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many parts have only cosmetic variants, with little or no mesh changes. There is no need to be generating multiple drag cubes for these, so useMultipleDragCubes is turned off for ModulePartVariants.
Some parts are hollow in ReStock that weren't in stock, this fixes that by using the YN and YP values from their stock counterparts in their drag cubes.
The new stock toroid tank does not use correct drag cubes, but the old version does, so the ReStock drag cube takes its YN/YP values from the old version.
For the 0.625m heat shield the drag cube from the config was removed and instead it will generate cubes for the shrouded and unshrouded versions; the same behavior as the other heat shields.