Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 page #107

Merged
merged 5 commits into from Jul 30, 2022
Merged

404 page #107

merged 5 commits into from Jul 30, 2022

Conversation

NabajitS
Copy link
Contributor

Description

Created a new page404 component inside app/src/Pages/
The route to this page was set up app/src/app.js using react-router-dom.
Additional - A Font was imported from google fonts

Fixes # (issue)
Created 404 page

Motivation and Context

It's a 404 page
Issue#65

How Has This Been Tested?

It, has been tested locally.

Screenshots (if appropriate)

404page

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • This PR isn't a duplicate of a previous one

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 🙌. Thanks for your contribution. Please make sure you've followed the contribution guidelines.

@NabajitS
Copy link
Contributor Author

I have no idea as to why these checks are failing.
I just made changes to the UI
I'm quite new to open source, so could you please point it out

@sudip-mondal-2002
Copy link
Member

sudip-mondal-2002 commented Jul 24, 2022

@NabajitS don't worry about it.
Update as suggested.

@NabajitS
Copy link
Contributor Author

Is there any problem with my PR ?
I would love to get some feedback

@sudip-mondal-2002
Copy link
Member

I have requested some updates in your code, this is minor change, please do that. rest all very fine.

@NabajitS
Copy link
Contributor Author

@sudip-mondal-2002 sorry but what do you mean?
Where do I look?

@sudip-mondal-2002
Copy link
Member

image

@NabajitS
Copy link
Contributor Author

Done, sorry about that.

@sudip-mondal-2002 sudip-mondal-2002 merged commit 0165284 into cyboholics:master Jul 30, 2022
@sudip-mondal-2002 sudip-mondal-2002 added SSOC Intermediate SSOC: Intermediate Level labels Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Intermediate SSOC: Intermediate Level SSOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants