Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Order.cancel API #2

Open
andychongyz opened this issue Sep 28, 2020 · 5 comments
Open

Add new Order.cancel API #2

andychongyz opened this issue Sep 28, 2020 · 5 comments
Labels

Comments

@andychongyz
Copy link
Collaborator

Add 2 functions:

  1. Check if order is cancelable based on status and cutoff time
  2. Order.cancel to send request to cancel the order There's the API doc
@syamphanindra
Copy link

Can I pick this issue??

@andychongyz
Copy link
Collaborator Author

Hi @syamphanindra, of course! Please go ahead! Btw, you will need to register for an account to test the API out http://apidocs.janio.asia/.

@syamphanindra
Copy link

syamphanindra commented Oct 18, 2020

Sure, Thank you, I will register.

@syamphanindra
Copy link

On this running this according to readme: bin/console
require': cannot load such file -- zeitwerk (LoadError) from /Users/syamphanindra/practice/opensource_contribution/janio_api/lib/dev/zeitwerk_loader.rb:1:in <top (required)>'
Is there any configuration I am missing.

@andychongyz
Copy link
Collaborator Author

andychongyz commented Oct 18, 2020

@syamphanindra Sorry, I have added the zeitwerk gem into the dev dependencies, please pull the latest master branch, and run bundle install again to get it installed, and you should be good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants