Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add @throws phpdoc comments to helper functions #149

Closed
arthurshafikov opened this issue Jun 22, 2023 · 2 comments
Closed

Please add @throws phpdoc comments to helper functions #149

arthurshafikov opened this issue Jun 22, 2023 · 2 comments

Comments

@arthurshafikov
Copy link

It's not always clear that a helper function can throw an exception, it has to have a phpdoc @throws comment.
image

For example lessThan function has an indicator that it throws an exception, I can see from that that I have to deal with this Exception by myself.
image

Also maybe you would like to add is_valid_money_string() function-helper or money_validate() to validate the string before parsing? I want to have a way of avoiding try/catch structures.

@PostScripton
Copy link
Owner

Hi, @arthurshafikov! Thank you for your the first issue on this repo.

I'll definitely add those exceptions to PHPDocs.
Thank you for reporting that 👍🏻

Speaking of additional helper method, I'll think of adding it, this seems useful 😉

@PostScripton
Copy link
Owner

@arthurshafikov, I've got updates on your issue.

That's been fixed here: #150
And released in this version: v4.1.1

I'll open a new issue for the new helper method that you've mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants