You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's not always clear that a helper function can throw an exception, it has to have a phpdoc @throws comment.
For example lessThan function has an indicator that it throws an exception, I can see from that that I have to deal with this Exception by myself.
Also maybe you would like to add is_valid_money_string() function-helper or money_validate() to validate the string before parsing? I want to have a way of avoiding try/catch structures.
The text was updated successfully, but these errors were encountered:
It's not always clear that a helper function can throw an exception, it has to have a phpdoc @throws comment.
![image](https://private-user-images.githubusercontent.com/60509074/247956630-33dcb88c-5af1-4b4c-aa0c-339e487d0c2e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA3OTU2NzUsIm5iZiI6MTcyMDc5NTM3NSwicGF0aCI6Ii82MDUwOTA3NC8yNDc5NTY2MzAtMzNkY2I4OGMtNWFmMS00YjRjLWFhMGMtMzM5ZTQ4N2QwYzJlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEyVDE0NDI1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBkNThlMjgxYThhYjk3MTk1MjhkOTczZmIxY2ZlMjEzMmYwMzI1NzY2MDIzM2Y2MGUyNzhhZDAyODA2Mzc4YWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.fgsSjilKg2yxw5LyVToD2qpMIi-pc4_bFddPWgNpiqA)
For example
![image](https://private-user-images.githubusercontent.com/60509074/247957189-cfc1382d-f966-4c2f-8cbf-3adeb9005fb2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA3OTU2NzUsIm5iZiI6MTcyMDc5NTM3NSwicGF0aCI6Ii82MDUwOTA3NC8yNDc5NTcxODktY2ZjMTM4MmQtZjk2Ni00YzJmLThjYmYtM2FkZWI5MDA1ZmIyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEyVDE0NDI1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlmYTZmZGNmM2U2MTMzYTYwMTI3ZGVhZWE2MmM5ZTg0OGYyMzM0YjQyMTk5NTIxODM2Nzg1OGI2M2EwM2E0NWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.0U7uVoFOaKmYbuvdNaTZkOBeiVLjcaDNgeUvoQp8Vfk)
lessThan
function has an indicator that it throws an exception, I can see from that that I have to deal with this Exception by myself.Also maybe you would like to add
is_valid_money_string()
function-helper ormoney_validate()
to validate the string before parsing? I want to have a way of avoiding try/catch structures.The text was updated successfully, but these errors were encountered: