Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ISO 8601 for dateTime and time values #49

Open
matthew-white opened this issue Jul 24, 2018 · 0 comments
Open

Support ISO 8601 for dateTime and time values #49

matthew-white opened this issue Jul 24, 2018 · 0 comments

Comments

@matthew-white
Copy link
Collaborator

matthew-white commented Jul 24, 2018

Some servers export dateTimes as ISO 8601 strings. I don't think the Stata clock() function can parse ISO 8601, but we should be able to modify the string before passing it to clock().

One of the reasons that clock() can't parse ISO 8601 is that clock() doesn't understand time zones, which are an optional part of ISO 8601. A time value can also include a time zone designator. For a time value, I think we can just strip the time zone designator, as Collect doesn't actually allow the user to select a time zone. I'm less sure what to do about dateTime values. Maybe we also strip their time zone designators, but issue a warning? Or maybe we can check whether all dateTime values are in the same time zone, and issue the warning only if they aren't? Alternatively, perhaps we could split the time zone into a separate variable? I doubt we want to implement any actual time zone conversion in Stata...

@matthew-white matthew-white changed the title Support ISO 8601 for dateTimes and times Support ISO 8601 for dateTime and time values Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant