Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Admin LTE & Bootstrap Upgrade #1371

Merged
merged 17 commits into from
Feb 17, 2023

Conversation

AgentTNT
Copy link
Contributor

@AgentTNT AgentTNT commented Feb 6, 2023

This would replace #1173

Convert col-xs-* to just col-* as part of bootstrap v3 -> v4
Convert box-* -> card-* as part of bootstrap v3 -> v4
Font Awesome v4 -> v5 (can go to v6 but small iterative updates first)
Moved domain actions on main dashboard to a dropdown menu to avoid clutter in rows
Added "Log Out" to top header left
Hid OTP on admin edit user to only show the disable card & options if the user account has OTP enabled
Certain modals were updated to fix positioning of the "X" within the header

login page has red card header to denote testing/danger and to not be used with prod systems right now

"flask assets build" takes a bit - will need to work on trimming this down
awesome fonts was moved from packages to be loaded in the CDN, but will convert back to packages when editing is done

Convert col-xs-* to just col-* as part of bootstrap v3 -> v4
Convert box-* -> card-* as part of bootstrap v3 -> v4
Moved domain actions on main dashboard to a dropdown menu to avoid clutter
Added "Log Out" to top header left
Hid OTP on admin edit user to only show the disable card & options if the user account has OTP enabled
@AgentTNT
Copy link
Contributor Author

AgentTNT commented Feb 6, 2023

Icons in buttons also started transition from right of text to left of text. Some buttons lack an icon at the moment, but will be resolved.

image
image
image
image

@AzorianMatt AzorianMatt added mod / reviewing This request is being reviewed feature / dependency Existing feature dependency labels Feb 7, 2023
@AzorianMatt AzorianMatt added this to the v0.4.0 milestone Feb 7, 2023
@AzorianMatt AzorianMatt added this to To do in Pull Requests Tracking via automation Feb 7, 2023
@AzorianMatt
Copy link
Member

@AgentTNT love the work you're doing, it is very appreciated to say the least! I'll be a little slow at getting merges done, but once I can test them, I'll get them through for you. Thank you!

Added server-side logic for register.html validation
Keep form firelds on register.html in the event of wrong input fields to save users from retyping info
More button rounding
"container-fluid" aditions
More button changes from flat to round and icon placement changes
First pass at HTML conversion from Master/Slave to Primary/Secondary (TODO: Backend)
Start work on migrating admin_auth_settings to Bootstrap v4
admin_setting_basic -> Change plain text for On/Off to toggles in current state, and changed "Action" column to the opposite toggle of current setting
dashboard_domain -> Reduce deuplicate code for the new dropdown-menu for Actions
register -> Add exclamation icon in front of error text
template_add -> changed box-body to card-body
user_profile -> Fixed tab naviation for Bootstrap v4. Tabs also fade between changes
@AzorianMatt AzorianMatt changed the title [WIP] Admin LTE & Bootstrap Uupgrade [WIP] Admin LTE & Bootstrap Upgrade Feb 14, 2023
@AzorianMatt AzorianMatt added the feature / update Existing feature modification label Feb 14, 2023
@AzorianMatt
Copy link
Member

AzorianMatt commented Feb 14, 2023

@AgentTNT here's what I have so far;

  • On the domain record page, let's keep the "Apply Changes" button aligned to the far right as it has been. I can see that this particular change would serve as an annoyance to those that are used to a speedy workflow using the old position.

So far, most things look great for the change over (as compared to their prior versions). I have many styling adjustments I want to make, but I'll save those for my pass after this is finished and merged.

@AzorianMatt AzorianMatt added mod / changes-requested Changes have been requested before proceeding mod / reviewed This request has been reviewed and removed mod / reviewing This request is being reviewed labels Feb 14, 2023
@AzorianMatt AzorianMatt added mod / accepted This request has been accepted and removed mod / changes-requested Changes have been requested before proceeding labels Feb 17, 2023
@AzorianMatt AzorianMatt marked this pull request as ready for review February 17, 2023 22:59
@AzorianMatt AzorianMatt merged commit 929cb63 into PowerDNS-Admin:master Feb 17, 2023
Pull Requests Tracking automation moved this from To do to Done Feb 17, 2023
AzorianMatt added a commit that referenced this pull request Feb 18, 2023
This reverts commit 929cb63, reversing
changes made to 0418edd.
AzorianMatt added a commit that referenced this pull request Feb 18, 2023
@AgentTNT AgentTNT deleted the AdminLTE-Upgrade branch February 21, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature / dependency Existing feature dependency feature / update Existing feature modification mod / accepted This request has been accepted mod / reviewed This request has been reviewed
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants