Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rec: structured logging for periodic stats #11654

Merged
merged 2 commits into from Jun 1, 2022

Conversation

omoerbeek
Copy link
Member

Short description

Also change the level to Info as that is the appropriate level: no action required. Notice is a level that might need action. The guidance in the OpenBSD man page is:

     LOG_EMERG     A panic condition.  This is normally broadcast to all
                   users.

     LOG_ALERT     A condition that should be corrected immediately, such as a
                   corrupted system database.

     LOG_CRIT      Critical conditions, e.g., hard device errors.

     LOG_ERR       Errors.

     LOG_WARNING   Warning messages.

     LOG_NOTICE    Conditions that are not error conditions, but should
                   possibly be handled specially.

     LOG_INFO      Informational messages.

     LOG_DEBUG     Messages that contain information normally of use only when
                   debugging a program.

IMO it would not hurt to review the syslog levels of the messages at some point, as we tend to use a non-adequate levels here and there.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@omoerbeek omoerbeek changed the title Rec: strcutured logging for periodic stats Rec: structured logging for periodic stats May 30, 2022
@omoerbeek omoerbeek requested a review from chbruyand May 30, 2022 10:13
@omoerbeek omoerbeek merged commit 7836df0 into PowerDNS:master Jun 1, 2022
@omoerbeek omoerbeek deleted the rec-logging-periodic-stats branch June 1, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants