Fix recursor not responsive after Lua config reload #11850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omoerbeek
requested changes
Aug 12, 2022
There was a problem hiding this comment.
It does compile with--disable-dnstap. But:
FrameStreamExportConfig and its methods can be moved into rec-main.cc
struct FrameStreamServersInfo can be moved into rec-main.hh inside the existing HAVE_FSTRM block.
and then check again if it compile both with --disable-dnstap and ``--enable-dnstap`
This also groups together 1) the list of frame stream servers, 2) the config from which the list was created and 3) the config's generation into a single struct called FrameStreamServersInfo. The struct is used to compare the old and new configuration to decide whether to destroy the old config object or not. Part of PowerDNS#11795
fredmorcos
force-pushed
the
fred/11795-fix-recursor-not-responsive-after-config-reload
branch
from
2ec9780
to
2e0757d
Compare
omoerbeek
approved these changes
Aug 15, 2022
fredmorcos
deleted the
fred/11795-fix-recursor-not-responsive-after-config-reload
branch
7 tasks
omoerbeek
added a commit
that referenced
this pull request
Aug 24, 2022
Backport #11850 (Fix recursor not responsive after Lua config reload) to rec 4.7.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Fixes #11795
Checklist
I have: