Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Fixes a few performance issues reported by Coverity #13092

Merged
merged 2 commits into from Aug 1, 2023

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Aug 1, 2023

Short description

I expected the compiler to already prevent the copy in the distributeAsyncFunction case, but looking at the actual allocations using heaptrack shows that this was not true, so we can actually prevent one allocation and copy in the pdns-distributes-queries case with this fix.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne merged commit f744551 into PowerDNS:master Aug 1, 2023
74 checks passed
@rgacogne rgacogne deleted the rec-coverity branch August 1, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants