Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: DOH - make query channel receiving part blocking #13147

Merged
merged 1 commit into from Aug 18, 2023

Conversation

chbruyand
Copy link
Member

@chbruyand chbruyand commented Aug 16, 2023

Short description

When not in single acceptor mode, the DOH thread processing incoming queries after they have been parsed is using 100% as the incoming channel is not blocking. This PR makes the receiving part to block.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@rgacogne
Copy link
Member

I introduced that bug in the channel PR, so after 1.8.0, fortunately..

@rgacogne
Copy link
Member

I think it's time to replace the booleans by enum class objects so it's clearer what they mean, I'll do that in a follow-up PR.

@rgacogne rgacogne merged commit 0ff5abb into PowerDNS:master Aug 18, 2023
74 checks passed
@chbruyand chbruyand deleted the dnsdist-channel-fix branch January 19, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants