Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR contains two ways to reduce RPZ memory usage:
unique_ptr
s for optional data in aPolicy
object. This reduces the memory used per RPZs by roughly 40% in typical cases.rec_control reload-lua-config
. Tested withrpzFile
andrec_control reload-lua-config
, but I suspectrpzPrimary
has the same issue.Fixes #13827 and fixes #12870 (duplicate)
Some memory usage data, first a clean startup wit a couple of RPZ loaded via
rpzPrimary()
:On another test with a couple of RPZs loaded wit
rpzFile
:Checklist
I have: