Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #1607

Closed
zeha opened this issue Jul 22, 2014 · 9 comments
Closed

Improve logging #1607

zeha opened this issue Jul 22, 2014 · 9 comments

Comments

@zeha
Copy link
Collaborator

zeha commented Jul 22, 2014

For the following reasons, the following stuff has been suggested:

Reasons:

  • test building log to syslog, where it's not useful
  • systemd captures stdout + syslog

Suggestions:

  • --log-stdout=on/off (better name?)
  • --log-syslog=on/off

Or some combination of those (--log-dest?)

@zeha zeha added auth labels Jul 22, 2014
@Habbie
Copy link
Member

Habbie commented Jul 22, 2014

It may be interesting to note that right now powerdns, internally, manages a loglevel for each and considers each line for both targets.

@Habbie
Copy link
Member

Habbie commented Jul 22, 2014

As such, we may want to expose that explicitly - give people even more control.

@zeha
Copy link
Collaborator Author

zeha commented Jul 22, 2014

For the future, direct journal logging support may also be nice.
Also, adding a printk-style priority to the stdout log may also be nice (for systemd users, but for those there should also be no extra date on the log line).

@zeha
Copy link
Collaborator Author

zeha commented Sep 15, 2014

The packages in jessie have enabled native systemd unit files in --daemon=no mode, therefore we now run into the duplicate logging/timestamping problem.

@jemshad
Copy link

jemshad commented Mar 16, 2015

Option to disable syslog logging would be great.

@eht16
Copy link

eht16 commented Sep 26, 2015

I support adding an option like --log-stdout=on/off, or better --log-stderr because pdns-recursor actually logs to stderr when not running in daemon-mode.

For now, I worked around the problem by adding StandardError=null to the systemd unit file and so I don't get duplicate logs any longer.

@nhooyr
Copy link

nhooyr commented Nov 4, 2015

would love to see this in the next release.

@Habbie Habbie added this to the auth-4.0.0 milestone Dec 15, 2015
@zeha
Copy link
Collaborator Author

zeha commented Jan 8, 2016

In the meantime, Debian has changed the systemd unit file to say Type=forking and changed --daemon=no to --daemon=yes. This has some benefits, and I'd suggest Debian users to do the same, for now. (Benefits include startup error tracking in systemd).

@Habbie
Copy link
Member

Habbie commented Mar 14, 2016

Decision: switch to Type=forking with --daemon in our packages now. At low priority, implement --disable-syslog or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants