Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report unparseable data in stoul invalid_argument exception #6396

Merged
merged 2 commits into from Mar 27, 2018
Merged

report unparseable data in stoul invalid_argument exception #6396

merged 2 commits into from Mar 27, 2018

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Mar 26, 2018 •
edited

Short description

This very slightly improves the #4450 situation. Ideally we'd log name/type but we don't have that information in the right place.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled and tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne rgacogne added this to the auth-4.1.x milestone Mar 27, 2018
@pieterlexis pieterlexis merged commit 0df9d29 into PowerDNS:master Mar 27, 2018
@Habbie Habbie deleted the stoul-data branch March 27, 2018 16:02
@Habbie Habbie mentioned this pull request May 1, 2018
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeha zeha zeha approved these changes

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
auth defect
Projects
None yet
Milestone
auth-4.1.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Habbie @zeha @rgacogne @pieterlexis