Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Exit when requested DoT/DoH support is not compiled in #7915

Merged
merged 1 commit into from Jun 12, 2019
Merged

dnsdist: Exit when requested DoT/DoH support is not compiled in #7915

merged 1 commit into from Jun 12, 2019

Conversation

rgacogne
Copy link
Member

Short description

We used to log to the console but happily start, and running --check would report no error (because it simulates client mode, see #7181).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Jun 12, 2019
@rgacogne rgacogne merged commit aa925a0 into PowerDNS:master Jun 12, 2019
@rgacogne rgacogne deleted the dnsdist-error-on-unsupported-addlocals branch June 12, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieterlexis pieterlexis pieterlexis approved these changes

Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rgacogne @pieterlexis