Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Remove needless id lookup #432

Closed
mgovers opened this issue Nov 21, 2023 · 2 comments · Fixed by #456
Closed

[Improvement] Remove needless id lookup #432

mgovers opened this issue Nov 21, 2023 · 2 comments · Fixed by #456
Assignees
@mgovers
Labels
good first issue Indicates a good issue for first-time contributors improvement Improvement on internal implementation

Comments

@mgovers
Copy link
Member

mgovers commented Nov 21, 2023

In #427 , the inverse update was implemented as an improved way to restore components after a batch update. The current implementation queries the id to sequence idx map once for each update step, and therefore once for the regular update, and once for the inverse update. That query is expensive.

The unneeded query may be removed by also caching the sequence idx in addition to the inverse update data.
@mgovers mgovers added improvement Improvement on internal implementation good first issue Indicates a good issue for first-time contributors labels Nov 21, 2023
@mgovers mgovers self-assigned this Dec 20, 2023
@mgovers mgovers mentioned this issue Dec 20, 2023
Merged
@mgovers
Copy link
Member Author

mgovers commented Jan 4, 2024

change reverted in #459 . This should be re-opened

@mgovers mgovers reopened this Jan 4, 2024
@mgovers
Copy link
Member Author

mgovers commented Mar 11, 2024 •
edited

The revert was reverted in #460 .

However, there is one follow-up task related to not always regenerate all calculation parameters. Edit: that is part of #337

@mgovers mgovers closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgovers mgovers

Labels
good first issue Indicates a good issue for first-time contributors improvement Improvement on internal implementation
Projects
Power Grid Model
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/remove needless id lookup PowerGridModel/power-grid-model
1 participant
@mgovers