Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] make tap_pos optional #576

Open
petersalemink95 opened this issue Apr 25, 2024 · 1 comment
Open

[FEATURE] make tap_pos optional #576

petersalemink95 opened this issue Apr 25, 2024 · 1 comment
Labels
feature New feature or request good first issue Indicates a good issue for first-time contributors

Comments

@petersalemink95
Copy link
Member

petersalemink95 commented Apr 25, 2024

For users that want to use the automatic tap changer power flow, it does not really matter what the original tap_pos is. They are just interested in the final tap_pos, found by the automatic tap algorithm. At this moment tap_pos is required, since it is necessary for the other algorithms.

We can make tap_pos optional, if we assign it the value of tap_nom when it is not given

@petersalemink95 petersalemink95 added feature New feature or request good first issue Indicates a good issue for first-time contributors labels Apr 25, 2024
@mgovers
Copy link
Member

mgovers commented Apr 26, 2024

current functionality clamps the tap position:

constexpr IntS tap_limit(IntS new_tap) const {
new_tap = std::min(new_tap, std::max(tap_max_, tap_min_));
new_tap = std::max(new_tap, std::min(tap_max_, tap_min_));
return new_tap;
}
(and idem for 3w-transformer).

this existing behaviour may impact users. if we decide that existing functionality is good enough, documentation should be improved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Indicates a good issue for first-time contributors
Projects
Status: No status
Development

No branches or pull requests

2 participants