Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xADGroup Applying MembersToInclude also changes GroupScope when not specified #183

Closed
mvaneijken opened this issue Feb 13, 2018 · 2 comments
Closed

xADGroup Applying MembersToInclude also changes GroupScope when not specified #183

mvaneijken opened this issue Feb 13, 2018 · 2 comments
Labels
bug The issue is a bug.

Comments

@mvaneijken
Copy link

xADGroup is changing the GroupScope of a Universal group to a Global group when using the following settings:

GroupName = "Group"
MembersToInclude = $UserName
MembershipAttribute = "SamAccountName"

Shouldn't it only add the member specified instead of changing other attributes of this group?
@johlju
Copy link
Member

johlju commented May 8, 2018

This happens because the default value is set to 'Global'. The resource should not change a value that is not part of a configuration.

https://github.com/PowerShell/xActiveDirectory/blob/4fa284e895760931ed651b8daed26c56dabac753/DSCResources/MSFT_xADGroup/MSFT_xADGroup.psm1#L280

@johlju johlju added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels May 8, 2018
@awickham10 awickham10 mentioned this issue May 23, 2018
Merged
johlju pushed a commit that referenced this issue May 25, 2018
@awickham10 @johlju
xADGroup no longer resets GroupScope and Category to default values (#…
f6d8e72 
…197)

- xADGroup no longer resets GroupScope and Category to default values ([issue #183](#183)).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label May 25, 2018
@johlju
Copy link
Member

johlju commented May 25, 2018

This was resolved in PR #197.

@johlju johlju closed this as completed May 25, 2018
johlju pushed a commit to johlju/ActiveDirectoryDsc that referenced this issue Apr 19, 2019
@awickham10 @johlju
xADGroup no longer resets GroupScope and Category to default values (d…
584227f 
…sccommunity#197)

- xADGroup no longer resets GroupScope and Category to default values ([issue dsccommunity#183](dsccommunity#183)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johlju @mvaneijken