Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xADUser: schema.mof has a version number different from all other resources. #190

Closed
johlju opened this issue May 9, 2018 · 0 comments
Closed

xADUser: schema.mof has a version number different from all other resources. #190

johlju opened this issue May 9, 2018 · 0 comments
Labels
bug The issue is a bug.

Comments

@johlju
Copy link
Member

johlju commented May 9, 2018

All resource has version 1.0.0.0 in the schema.mof, but xUser has 1.0.1.0. Unless there is a good reason for keeping it, I suggest we change xUser to use the same version number as all other resources.
@johlju johlju added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels May 9, 2018
thequietman44 added a commit to thequietman44/xActiveDirectory that referenced this issue Jun 12, 2018
@thequietman44
Changed MSFT_xADUser.schema.mof version to "1.0.0.0" to match other r…
02da48c 
…esources. Fixes dsccommunity#190
@thequietman44 thequietman44 mentioned this issue Jun 13, 2018
Merged
thequietman44 added a commit to thequietman44/xActiveDirectory that referenced this issue Jun 13, 2018
@thequietman44
Updated Unreleased section with fixes for dsccommunity#190 and dsccom…
0815f91 
…munity#198
johlju pushed a commit that referenced this issue Jun 13, 2018
@thequietman44 @johlju
Remove duplicate example in README.md and fix xADUser schema version (#…
ce57669 
…206)

- Changes to xActiveDirectory
  - Changed MSFT_xADUser.schema.mof version to "1.0.0.0" to match other resources (issue #190).
  - Removed duplicated code from examples in README.md (issue #198).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Jun 13, 2018
johlju pushed a commit to johlju/ActiveDirectoryDsc that referenced this issue Apr 19, 2019
@thequietman44 @johlju
Remove duplicate example in README.md and fix xADUser schema version (d…
b125228 
…sccommunity#206)

- Changes to xActiveDirectory
  - Changed MSFT_xADUser.schema.mof version to "1.0.0.0" to match other resources (issue dsccommunity#190).
  - Removed duplicated code from examples in README.md (issue dsccommunity#198).
@johlju johlju removed the good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub label Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johlju