Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xADDomainTrust: Integration tests is missing for this resource #348

Closed
johlju opened this issue Jun 7, 2019 · 1 comment · Fixed by #423
Closed

xADDomainTrust: Integration tests is missing for this resource #348

johlju opened this issue Jun 7, 2019 · 1 comment · Fixed by #423
Labels
tests The issue or pull request is about tests only.
Projects
All issues and PR's

Comments

@johlju
Copy link
Member

johlju commented Jun 7, 2019

We should add integration tests for this resource.
@johlju johlju added help wanted The issue is up for grabs for anyone in the community. tests The issue or pull request is about tests only. labels Jun 7, 2019
@johlju johlju added this to To do in All issues and PR's Jun 7, 2019
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jul 10, 2019
@johlju
Copy link
Member Author

johlju commented Jul 10, 2019

I'm currently finishing up refactoring this resource and completing unit tests, I will look into adding integration tests when I'm at it as I already have a lab setup with two forests.

johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 10, 2019
@johlju
Changes to xADDomainTrust
757356d 
- Added integration tests (issue dsccommunity#348).
@johlju johlju mentioned this issue Jul 10, 2019
Merged
9 tasks
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 11, 2019
@johlju
Changes to xADDomainTrust
8ae34f1 
- Added integration tests (issue dsccommunity#348).
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 12, 2019
@johlju
Changes to xADDomainTrust
e0bc9ec 
- Added integration tests (issue dsccommunity#348).
All issues and PR's automation moved this from To do to Done Jul 13, 2019
johlju added a commit that referenced this issue Jul 13, 2019
@johlju
xADDomainTrust: Refactor resource and add tests (#423)
dd53b43 
- Changes to xActiveDirectory
  - Added new helper functions in xActiveDirectory.Common.
    - New-CimCredentialInstance
    - Add-TypeAssembly
    - New-ADDirectoryContext
- Changes to xADDomainTrust
  - Refactored the resource to enable unit tests, and at the same time changed
    it to use the same code pattern as the resource xADObjectEnabledState.
  - Added unit tests (issue #324).
  - Added comment-based help (issue #337).
  - Added integration tests (issue #348).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests The issue or pull request is about tests only.
Projects
All issues and PR's
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xADDomainTrust: Refactor resource and add tests johlju/ActiveDirectoryDsc
1 participant
@johlju