Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource discovery optimizations #240

Merged
merged 20 commits into from Oct 31, 2023
Merged

Resource discovery optimizations #240

merged 20 commits into from Oct 31, 2023

Conversation

anmenaga
Copy link
Collaborator

PR Summary

Fix #121
Fix #173

PR Context

This PR changes resource discovery behavior as per #121 ,
There is also some perf optimizations added such as:

  • early termination of discovery once all required resources for the operation are found;
  • discovery of provider-based resources is done after discovery of native resources;
  • no longer use RegEx for type name matching when not needed (previously was used for all operations).

SteveL-MSFT
SteveL-MSFT reviewed Oct 26, 2023
View reviewed changes
dsc/src/main.rs Outdated Show resolved Hide resolved
SteveL-MSFT
SteveL-MSFT requested changes Oct 26, 2023
View reviewed changes
dsc/src/resource_command.rs Outdated Show resolved Hide resolved
dsc/src/resource_command.rs Outdated Show resolved Hide resolved
dsc/src/resource_command.rs Outdated Show resolved Hide resolved
dsc/src/resource_command.rs Outdated Show resolved Hide resolved
dsc/src/resource_command.rs Outdated Show resolved Hide resolved
dsc_lib/src/discovery/command_discovery.rs Outdated Show resolved Hide resolved
dsc_lib/src/discovery/command_discovery.rs Outdated Show resolved Hide resolved
dsc_lib/src/discovery/mod.rs Outdated Show resolved Hide resolved
dsc_lib/src/discovery/mod.rs Outdated Show resolved Hide resolved
dsc_lib/src/discovery/mod.rs Outdated Show resolved Hide resolved
SteveL-MSFT
SteveL-MSFT requested changes Oct 31, 2023
View reviewed changes
dsc/src/resource_command.rs Outdated Show resolved Hide resolved
dsc/src/resource_command.rs Show resolved Hide resolved
dsc/tests/dsc_args.tests.ps1 Show resolved Hide resolved
dsc_lib/src/configure/mod.rs Outdated Show resolved Hide resolved
@SteveL-MSFT
Copy link
Member

@michaeltlombardi as part oft his change, individual resource execution will no longer take a wildcard. There's a new issue opened if we need this back.

@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Oct 31, 2023
Merged via the queue into PowerShell:main with commit 7950e11 Oct 31, 2023
4 checks passed
michaeltlombardi added a commit to michaeltlombardi/DSC that referenced this pull request Nov 8, 2023
@michaeltlombardi
(DOCS) Add resource discovery updates to CHANGELOG
39dc62e 
This change adds changelog entries for PowerShell#240 to the CHANGELOG.
@michaeltlombardi michaeltlombardi mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

Assignees
No one assigned
Labels
Doc-Impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discovery optimizations Make resource discovery not terminating when hitting an error depending on use case
2 participants
@anmenaga @SteveL-MSFT