Fix parameters to work with property values #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
force-pushed
the
validate-after-expression
branch
from
8636d14
to
b7465c8
Compare
3 tasks
michaeltlombardi
added a commit
to michaeltlombardi/DSC
that referenced
this pull request
Feb 5, 2024
This change adds documentation to the CLI and schema reference for the parameters support implementation in PowerShell#291 and PowerShell#294. It also updates the changelog with the relevant information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Before this PR, resources were being statically validated against their schema. This fails because a property value may use an expression and that string may fail schema validation as the expression hasn't been invoked yet. This change moves resource input validation later when the resource is actually getting invoked and expressions have been invoked.
There was also an issue where string parameters were being returned enclosed in quotes, this PR also fixes that issue.
Also added mock
validateimplementation for PowerShellGroup and WmiGroup resources rather than have code in DSC to skip validation.